Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix missing async in createServer callback #20

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Docs: fix missing async in createServer callback #20

merged 3 commits into from
Sep 14, 2024

Conversation

gregnr
Copy link
Contributor

@gregnr gregnr commented Sep 13, 2024

Our Node.js createServer callback needs to be async now that fromNodeSocket() is async. This fixes the docs to add this.

HT @BracketJohn 🫡

@gregnr gregnr merged commit 561fa36 into next Sep 14, 2024
1 check passed
@gregnr gregnr deleted the docs/fix-missing-async branch September 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgoux jgoux jgoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregnr @jgoux