Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore hash if local secret is unset #3012

Merged
merged 2 commits into from
Jan 3, 2025
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 3, 2025

What kind of change does this PR introduce?

Bug fix

What is the new behavior?

If local secret is unset, no need to diff with platform defaults.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 3, 2025 09:07
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12595422178

Details

  • 19 of 30 (63.33%) changed or added relevant lines in 1 file are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 59.673%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/config/auth.go 19 30 63.33%
Files with Coverage Reduction New Missed Lines %
internal/debug/postgres.go 3 64.86%
internal/gen/keys/keys.go 5 12.9%
Totals Coverage Status
Change from base Build 12593707873: -0.06%
Covered Lines: 7665
Relevant Lines: 12845

💛 - Coveralls

@sweatybridge sweatybridge merged commit 7c9f8c9 into develop Jan 3, 2025
9 checks passed
@sweatybridge sweatybridge deleted the ignore-hash branch January 3, 2025 09:21
@github-actions github-actions bot mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants