-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to delete by filtering metadata only #57
Conversation
Deleting by metadata sounds reasonable. I think the right way to approach it would be to overload the existing Something like: From def delete(self, ids: Iterable[str]) -> List[str]: To def delete(self, ids: Optional[Iterable[str]] = None, filters: Optional[Metadata] = None) -> List[str]: where |
@olirice thank you, I updated the method and the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, thank you! |
What kind of change does this PR introduce?
Feature
What is the current behavior?
I need to be able to delete vectors based solely on their metadata but currently the only way to do so is to already have the ids.
What is the new behavior?
I added 2 methods as suggestions.
Option #1: add a
delete_by_metadata
Option #2:
delete_vectors
(temporary name) a suggestion for updating the currentdelete
function to allow optionally passing the ids or metdata (one or the other).Please let me know which is an acceptable approach and if there are any objections to having this capability.