Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken test build #1191

Open
wants to merge 1 commit into
base: lockhart
Choose a base branch
from

Conversation

marwoodandrew
Copy link
Contributor

No description provided.

@marwoodandrew marwoodandrew force-pushed the fix-build-attempt branch 11 times, most recently from aa08cf0 to 80036e5 Compare August 7, 2024 05:51
@marwoodandrew marwoodandrew force-pushed the fix-build-attempt branch 4 times, most recently from a5faa7f to 862ad26 Compare August 13, 2024 07:08
@MarkLark86
Copy link
Contributor

@marwoodandrew Wondering if this could be an issue with the version of pytest being used: https://github.com/superdesk/newsroom/blob/lockhart/dev-requirements.txt#L6. It is rather an old version

@marwoodandrew marwoodandrew force-pushed the fix-build-attempt branch 6 times, most recently from c2f097a to da2263c Compare August 16, 2024 06:39
@marwoodandrew
Copy link
Contributor Author

@MarkLark86 Well all I seem to have done is find a sophisticated way to stop the tests from running, I'll look again next week. (still don't think the actual build will build due to the pip problem, but can't see how I can fix it, I think It's building under python 3.10!

@MarkLark86
Copy link
Contributor

@marwoodandrew Looks like you're getting there. The ipaddress module doesn't seem to like 123.123.123.001 address.

>>> import ipaddress
>>> ipaddress.ip_network("123.123.123.001", strict=True)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/marklark/miniconda3/envs/async-nhub-tests/lib/python3.10/ipaddress.py", line 83, in ip_network
    raise ValueError(f'{address!r} does not appear to be an IPv4 or IPv6 network')
ValueError: '123.123.123.001' does not appear to be an IPv4 or IPv6 network
>>>
>>>
>>> ipaddress.ip_network("123.123.123.1", strict=True)
IPv4Network('123.123.123.1/32')
>>>

Try replacing the 001 with just 1 and see how that goes with the tests

@marwoodandrew
Copy link
Contributor Author

@MarkLark86 Tests pass! final build fails, due I think to the version of pip, but can't see where I can change that!

@MarkLark86
Copy link
Contributor

You can't, that's on our test infrastructure (using FireQ).

@MarkLark86
Copy link
Contributor

The problem is our test server now uses Python v3.10, and I believe a newer version Cerberus is required to support it. Which requires looking at Superdesk & Eve to see if you can update the version to a newer one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants