Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTRL-C will now exit the program #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Luk164
Copy link

@Luk164 Luk164 commented Apr 2, 2021

Just a simple piece of code added to the end of the file + two booleans to check if files are being written to. Also does not allow files to be written while shutting down and will automatically reject incoming connections. Relates to issue #13

Just a simple piece of code added to the ned of the file + two booleans to check if files are being written to.
@Juankz
Copy link

Juankz commented Jul 27, 2021

I tested this PR but it isn't working for me. If don't save any changes it shutdows with Ctrl-C. But after I have saved any change in the scene Ctrl-C no longer works

@Juankz
Copy link

Juankz commented Jul 27, 2021

Update: Seems to be a problem with the package prompt-confirm capturing the input and not reporting the SIGINT signal. See enquirer/prompt-confirm#9

@Luk164
Copy link
Author

Luk164 commented Aug 2, 2021

@Juankz That repo seems to be dead, I dont really know how to proceed here

@Juankz
Copy link

Juankz commented Aug 2, 2021

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

@Luk164
Copy link
Author

Luk164 commented Aug 3, 2021

I talked on discord with one of the maintainers, the repo is not dead but is not much active either. If you could help testing my PR it would make it easier to merge.

I do not see any PRs from your account there, could you drop a link?

@Juankz
Copy link

Juankz commented Aug 3, 2021

Sure #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants