Update QHull and BuildMacOS.sh to support debug and XCode builds #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix createrelease as the mac arm can't be compiled on github anymore
Added a piece of code into handle_legacy to check for aliases. '.mf3 files won't open 2.4.58.3' supermerill#2939
…one click instead of two (recovering the old behavior).
Mitigation: remove shallow angles that seems to make it appear. As the previous remove_colinear was on a fixed dist (taht became too small on long segments) I created a new one that work from an angle. supermerill#2971
And fix for the visualization of the spiral start.
…rientation or the scale of a part of a multipart object
…xtra frame the first time an imgui window is shown
Fixed division by zero on zero length extrusions. Added bunch of asserts to check for divisions by zero.
- contiguous: even more aligned - scattered: old random: random per island per layer - random : new random: every loop has its own random seam.
updated doc in readme supermerill#2930
Also, can now use {tool_name} and other filaments & extruder settings in filament start/end
supermerill#2934
established names.
Tips for updating on the RPI4.
updated Qhull.cmake to add patch to the imported Qhull CMakeLists.txt so that it creates correctly named debug libraries.
nanoplane
changed the title
|
The Qhull CMakeLists.txt directives in the original change the name of Debug Libraries resulting in library names having an "_dd" suffix added rather than just a "d" suffix added. The patch comments out the change and always just defines the base names with no suffix, allowing the overall cmake rule to apply. The second change modifies BuildMacOS.sh to support building an Xcode project using : BuildMacOS.sh -c |
supermerill
pushed a commit
that referenced
this pull request
Apr 25, 2023
updated Qhull.cmake to add patch to the imported Qhull CMakeLists.txt so that it creates correctly named debug libraries. #3173
|
merged, will check if it's okay with the auto build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Qhull.cmake to add patch to the imported Qhull CMakeLists.txt so that it creates correctly named debug libraries.
This allows working debug libraries to be built under MacOS.
A second change in BuildMacOS.sh allows Xcode builds.