Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extraScope can access in trigger rules #382

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

golfapipol
Copy link
Contributor

uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules
use options.system.extraScope instead of old one

Description

uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules
use options.system.extraScope instead of old one

Motivation and Context

I want to use extraScope in trigger rules and found this commented code here

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

uncommnet line:156 in helpers.js that make extraScope cannot use in trigger rules
	modified:   src/bot/getReply/helpers.js
@coveralls
Copy link

coveralls commented Oct 4, 2017

Coverage Status

Coverage increased (+0.07%) to 80.565% when pulling 04d1978 on golfapipol:make-extraScope-work-in-getReply into d7cf87a on superscriptjs:master.

@golfapipol
Copy link
Contributor Author

I think we should change filterScope.message_props to filterScope.extraScope or not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants