Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Code Review comments suggestions added

Co-authored-by: Przemyslaw Hugh Kaznowski <hughkaznowski@protonmail.com>
  • Loading branch information
sbshah97 and phughk authored Jan 7, 2024
1 parent c4815d7 commit f1713c4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions db_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ func (s *SurrealDBTestSuite) TestFetch() {

// User rows are individually fetched
s.Run("Run fetch for individual users", func() {
s.T().Skip("Not working, check https://github.com/surrealdb/surrealdb.go/issues/116")
s.T().Skip("TODO(gh-116) Fetch unimplemented")
for _, v := range userSlice {
res, err := s.db.Query("select * from $table fetch $fetchstr;", map[string]interface{}{
"record": v.ID,
Expand All @@ -285,18 +285,17 @@ func (s *SurrealDBTestSuite) TestFetch() {
})

s.Run("Run fetch on query using map[string]interface{} for thing and fetchString", func() {
s.T().Skip("Not working, check https://github.com/surrealdb/surrealdb.go/issues/116")
s.T().Skip("TODO(gh-116) Fetch unimplemented")
res, err := s.db.Query("select * from $record fetch $fetchstr;", map[string]interface{}{
"record": "users",
"fetchstr": "friends.*",
})
// TODO: This should be fixed once the code is fixed
s.NoError(err)
s.NotEmpty(res)
})

s.Run("Run fetch on query using map[string]interface{} for fetchString", func() {
s.T().Skip("Not working, check https://github.com/surrealdb/surrealdb.go/issues/116")
s.T().Skip("TODO(gh-116) Fetch unimplemented")
res, err := s.db.Query("select * from users fetch $fetchstr;", map[string]interface{}{
"fetchstr": "friends.*",
})
Expand Down

0 comments on commit f1713c4

Please sign in to comment.