Add context.Context support to the API #121
Open
+148
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change adds context.Context support to the APIs. The context is currently unused and just serves as an API change before more functionality is added (eg. tracing). This is is a breaking API change.
|
Hi @VoyTechnology, Thanks for your PR. I understand the importance of using contexts, but I'm not sure we should add them while we're not utilizing them in a useful way yet. We should also consider that we'll be making some major changes in the future to try to be compatible with the golang standard interface (database/sql). Once these changes are implemented, I think we could then consider adding contexts. Please let me know what you think. We can discuss this further if you'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds context.Context support to the APIs. The context is
currently unused and just serves as an API change before more
functionality is added (eg. tracing).
This is a breaking API change.
Closes #100