Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
There is value for some scenarios being able to obtain a JSON representation of the response like you were able to do with the pre-v1 version of the JS library.
What does this change do?
This PR implements
toJSON
methods where required to make this possibly again.Additionally, this PR also introduces a
StringRecordId
class, which will send over the string record id to the server to leave it to parse it.Here's a simple example of what you will now be able to do:
What is your testing strategy?
Added a snapshot-based unit test which compares the JSON-encoded value against a snapshot of what it should be. Also added a test to ensure that a string record id sent to the server is properly parsed by the server.
Is this related to any issues?
flatMode
flag to flatten surrealdb responses to plain js objects #244Have you read the Contributing Guidelines?