Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tvl-chart.tsx #1738

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

famouswizard
Copy link

Снимок экрана 2024-10-30 в 12 06 30

Lack of data presence check:

In const xData = (data.v2.length > data.v3.length ? data.v2 : data.v3).map(...), you do not check if there is data in data.v2 and data.v3. If both arrays are empty, it may cause an error.

Fixed.

Lack of data presence check. Fixed.
Copy link

vercel bot commented Oct 30, 2024

Deployment failed with the following error:

There is no GitHub account connected to this Vercel account.

Copy link

vercel bot commented Oct 30, 2024

@famouswizard is attempting to deploy a commit to the Sushi Team on Vercel.

A member of the Team first needs to authorize it.

@LufyCZ
Copy link
Collaborator

LufyCZ commented Oct 30, 2024

Снимок экрана 2024-10-30 в 12 06 30

Lack of data presence check:

In const xData = (data.v2.length > data.v3.length ? data.v2 : data.v3).map(...), you do not check if there is data in data.v2 and data.v3. If both arrays are empty, it may cause an error.

Fixed.

Hey, thanks for the PR :). Looks like you deleted the useMemo line by mistake though.

@famouswizard
Copy link
Author

Снимок экрана 2024-10-30 в 12 06 30 **Lack of data presence check:** In `const xData = (data.v2.length > data.v3.length ? data.v2 : data.v3).map(...)`, you do not check if there is data in `data.v2` and `data.v3`. If both arrays are empty, it may cause an error. Fixed.

Hey, thanks for the PR :). Looks like you deleted the useMemo line by mistake though.

Oops. It's fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants