Found a more general solution to identify rpm and deb envs #1111
mwester117ansible-test.yml
on: push
ansible-lint
/
Ansible Lint
25s
sanity
/
Matrix Sanity
14s
Matrix: sanity / test
all_green
0s
Annotations
10 warnings
|
jinja[spacing]:
roles/install_agent/vars/main.yml#L3
Jinja2 spacing could be improved: {% if ansible_facts.pkg_mgr in ['yum', 'dnf', 'zypper'] %}rpm{% elif ansible_facts.pkg_mgr == 'apt' %}deb{% elif ansible_facts.os_family == 'Windows' and not win_use_exe %}msi{% elif ansible_facts.os_family == 'Windows' and win_use_exe %}exe{% else %}unknown{% endif %} -> {% if ansible_facts.pkg_mgr in ['yum', 'dnf', 'zypper'] %}rpm{% elif ansible_facts.pkg_mgr == 'apt' %}deb{% elif ansible_facts.os_family == 'Windows' and not win_use_exe %}msi{% elif ansible_facts.os_family == 'Windows' and win_use_exe %}exe{% else %}unknown{% endif %}
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L3
Variables names from within roles should use install_agent_ as a prefix. (vars: win_use_exe)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L4
Variables names from within roles should use install_agent_ as a prefix. (vars: win_allow_reboot)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L5
Variables names from within roles should use install_agent_ as a prefix. (vars: agent_version)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L6
Variables names from within roles should use install_agent_ as a prefix. (vars: hide_sensitive)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L7
Variables names from within roles should use install_agent_ as a prefix. (vars: lx_force_new_token)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L8
Variables names from within roles should use install_agent_ as a prefix. (vars: check_console_retries)
|
|
var-naming[no-role-prefix]:
roles/install_agent/defaults/main.yml#L9
Variables names from within roles should use install_agent_ as a prefix. (vars: check_console_retry_delay)
|
|
command-instead-of-module:
roles/install_agent/tasks/Linux.yml#L43
rpm used in place of yum or rpm_key module
|
|
no-changed-when:
roles/install_agent/tasks/Linux.yml#L86
Commands should not change things if nothing needs doing.
|