Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename into_array to octets. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

reitermarkus
Copy link
Contributor

@reitermarkus reitermarkus commented Mar 27, 2022

The name into_array feels a bit out of place. Most methods of this type in the standard library are called to_bytes taking &self. The IpAddr types call it octets however.

Given there is already as_bytes, maybe calling it to_bytes is the better option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant