Optimized nib logic + updated internal docs

sveinbjornt · Oct 4, 2023 · 67574e7 · 67574e7
1 parent c18f9bf
commit 67574e7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/Application/PlatypusWindowController.m b/Application/PlatypusWindowController.m
@@ -418,7 +418,8 @@ - (BOOL)createApplication:(NSString *)destination {
     spec[AppSpecKey_SymlinkFiles] = @((BOOL)[createSymlinksCheckbox intValue]);
     spec[AppSpecKey_StripNib] = @((BOOL)[stripNibFileCheckbox intValue]);
     if (spec[AppSpecKey_StripNib]) {
-        spec[AppSpecKey_NibPath] = [[NSBundle mainBundle] pathForResource:CMDLINE_NIB_OPT_NAME ofType:nil];;
+        spec[AppSpecKey_NibPath] = [[NSBundle mainBundle] pathForResource:CMDLINE_NIB_OPT_NAME ofType:nil];
+        // spec[AppSpecKey_StripNib] = @(NO);
     }
     spec[AppSpecKey_Overwrite] = @YES;
     if (![[DEFAULTS stringForKey:DefaultsKey_SigningIdentity] isEqualToString:@"None"]) {

diff --git a/Application/Resources/Platypus-Info.plist b/Application/Resources/Platypus-Info.plist
@@ -411,7 +411,7 @@
 	<key>CFBundleSignature</key>
 	<string>????</string>
 	<key>CFBundleVersion</key>
-	<string>1251</string>
+	<string>1252</string>
 	<key>LSApplicationCategoryType</key>
 	<string>public.app-category.developer-tools</string>
 	<key>LSMinimumSystemVersion</key>

diff --git a/CHANGES.txt b/CHANGES.txt
@@ -22,9 +22,10 @@ For future versions...
     TODO: Harden CI testing for this old project
     TODO: Fix selection change when item is deleted from the Bundled Files List
 
-For 5.4.2 - 02/10/2023
+For 5.4.2 - 03/10/2023
     * Fixed bug where the argument settings window would lock up
-    TODO: Keep an optimized copy of the nib in app bundle to save expensive step when creating
+    * Better support for Dark Mode
+    * Performance optimizations in the app build process
 
 For 5.4.1 - 22/10/2022
     * Fixed signing issues