Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency typescript to ~5.3.0 #574

Merged
merged 12 commits into from
Jan 20, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 24, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) ~5.1.0 -> ~5.3.0 age adoption passing confidence

Release Notes

Microsoft/TypeScript (typescript)

v5.3.3: TypeScript 5.3.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.3.2: TypeScript 5.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.2.2: TypeScript 5.2

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

⚠️ No Changeset found

Latest commit: 943f059

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@renovate renovate bot force-pushed the renovate/typescript-5.x branch 2 times, most recently from 85f0f21 to 24122b1 Compare September 4, 2023 14:36
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 2 times, most recently from 507a07e to 6e61c01 Compare September 9, 2023 12:01
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 3 times, most recently from 84d435e to 430b606 Compare September 22, 2023 22:06
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 4 times, most recently from be7161e to 66f49d4 Compare October 4, 2023 09:00
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 4 times, most recently from dfb8911 to 32ecfc6 Compare October 19, 2023 14:30
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 3 times, most recently from 96c7664 to 017f8e6 Compare October 24, 2023 09:52
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 7 times, most recently from c629f78 to 7940822 Compare November 6, 2023 18:30
@renovate renovate bot force-pushed the renovate/typescript-5.x branch from 7940822 to 4bb315b Compare November 13, 2023 04:23
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 3 times, most recently from 217edd7 to 9199ea5 Compare November 20, 2023 12:54
@renovate renovate bot force-pushed the renovate/typescript-5.x branch 10 times, most recently from 0a678d8 to 710c5d8 Compare January 16, 2024 14:56
@renovate renovate bot force-pushed the renovate/typescript-5.x branch from 710c5d8 to da19f02 Compare January 18, 2024 17:30
@renovate renovate bot force-pushed the renovate/typescript-5.x branch from da19f02 to 299da21 Compare January 19, 2024 00:17
Copy link
Contributor Author

renovate bot commented Jan 20, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@baseballyama
Copy link
Member

In tsconfig.json, I specified "module": "NodeNext" and explicitly specified "type": "commonjs" in package.json. I checked that the built file kept commonjs.
Then, for some reason, I faced a issue that CI didn’t pass. On my local . Node.js v20.8.1 and the test passed. However, when I upgraded to v20.10.0, the tests no longer pass. I honestly don't know why. However, I also found that if I add several files to the tests directory that I think I forgot to commit, the tests pass.
In any case, this doesn't seem to be a TypeScript issue, but rather a Node.js issue, so after merging this PR, we can consider how to deal with the issue when it occurs again. In any case, this issue is not relevant to end users, so I don't think it will have a big impact if we move on with this issue.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 89a30e2 into main Jan 20, 2024
12 checks passed
@ota-meshi ota-meshi deleted the renovate/typescript-5.x branch January 20, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants