-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update store documentation #14083
base: main
Are you sure you want to change the base?
Conversation
…the rest of it is still better handled with classes and effects. we shouldn't be encouraging people to create new stores
|
commit: |
while I agree in general, I don't want the solution to be stuffing a whole bunch of content into JSDoc. We had this dilemma elsewhere, I think it's time to enhance the auto-generation from d.ts - you should be able to declare additional documentation (or documentation that is used in place of the jsdoc comment) in some markdown file and the generation script stitches them together accordingly. |
Is the concern that it's annoying to do so (which is true!) or that you don't want that documentation to be present when people hover over stuff in their editor? Because I can't really think of a situation where I wouldn't want the comprehensive documentation to be at my fingertips |
|
I agree with this, while the JSDoc definitions may seem a little long, they're extremely useful. Svelte isn't that hard to understand, but it's good to get a refresher of how to use certain features if you're new or a little rusty (and don't want to have to dig through documentation to find info) |
It doesn't really make sense to have a whole load of documentation on
svelte/store
on/docs/svelte/stores
page and then again on/docs/svelte/svelte-store
. The first should describe the store contract at a high level, while the second should detail the things you can import from the module.This is draft because we really need to fix the way overloads are handled first — it's too confusing at the moment