Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove orphan pluralizations #1017

Merged
merged 7 commits into from
Aug 23, 2022
Merged

Remove orphan pluralizations #1017

merged 7 commits into from
Aug 23, 2022

Conversation

digitalfrost
Copy link
Collaborator

  • Deleted orphan pluralizations and corresponding specs.
  • Added spec to test for orphan pluralizations.
  • Enabled Rspec to use both should and expect syntax

#1011 #577

Enables the same code to be used in thor and rspec
Check that they are no pluralization files that do not
have a corresponding locale.yml file

Also enabled both Rspec should and expect syntax
Deleted 48 orphan pluralizations that do not have a corresponding
locale file.
Remove pluralization specs for orphan pluralizations
since these pluralizations have been deleted
Existing orphans have been deleted.
The CI should fail if new orphans are added.
Added list of removed pluralizations to the README.
@pama pama merged commit 418dd73 into svenfuchs:master Aug 23, 2022
@pama
Copy link
Collaborator

pama commented Aug 23, 2022

Thank you!

kevindew added a commit to alphagov/govuk_app_config that referenced this pull request Nov 15, 2022
The 7.0.6 release of rails-i18n dropped support for a number of plurals
[1] and this causes our apps that make use of these languages to error
and thus be unable to update to rails-i18n 7.0.6

This commit ports over these rules from rails-i18n to maintain the
behaviour.

There is also something of a duplicate of this file in
[rails_translation_manager](https://github.com/alphagov/rails_translation_manager/blob/main/config/locales/plurals.rb)
that may also need an update. I'm unsure of the status of that file
though as it is already out-of-sync with this one and I think this one
takes priority.

[1]: svenfuchs/rails-i18n#1017
chao-xian added a commit to alphagov/rails_translation_manager that referenced this pull request Nov 16, 2022
The 7.0.6 release of rails-i18n dropped support for a number of plurals
[1] and this causes our apps that make use of these languages to error
and thus be unable to update to rails-i18n 7.0.6

This commit ports over these rules from rails-i18n to maintain the
behaviour.

This update follows what was added into govuk_app_config [2]

[1]: svenfuchs/rails-i18n#1017
[2]: alphagov/govuk_app_config#266
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants