Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: postman swag addition #1271

Merged

Conversation

Tejas-Sharma-dev
Copy link
Contributor

@Tejas-Sharma-dev Tejas-Sharma-dev commented Oct 3, 2024

updated data.json for new swag oppurtunity as mentioned in issue #1270.

fixes #1270

please review the difficulty and description, if its relevant or not.

  • I've checked that this isn't a new swag opportunity proposal.
  • I've checked that this isn't a duplicate pull request.

Please review the changes made in data.json and I have used the postman contributor program logo for image,
as t-shirt image is not provided.

reference image (not sure exact this t-shirt): https://store.postman.com/collections/products/products/blue-logo-shirt

updated data.json for new swag oppurtunity as mentioned in issue#1270.

please review the difficulty and description, if its relevant or not.
@Tejas-Sharma-dev Tejas-Sharma-dev changed the title fixes #1270 postman swag addition fixes #1270: postman swag addition Oct 3, 2024
updated data.json file, it was missing seperator ',' between two objects.
@aslafy-z
Copy link
Collaborator

aslafy-z commented Oct 3, 2024

@Tejas-Sharma-dev LGTM

AFAIK, the fixes #1270 mention should be in the PR body, not in the title.

@aslafy-z aslafy-z changed the title fixes #1270: postman swag addition feat: postman swag addition Oct 3, 2024
data.json Outdated Show resolved Hide resolved
@aslafy-z aslafy-z merged commit 2c0dbac into swapagarwal:master Oct 3, 2024
2 checks passed
@Tejas-Sharma-dev Tejas-Sharma-dev deleted the fix-1270-add-postman-swag branch October 3, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postman swag oppurtunity
2 participants