fix(es/minifier): Preserve flags while dropping elements of SeqExpr
#8907
+126
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e03eb6 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kdy1
reviewed
May 5, 2024
| // TODO: preserve PURE comment attached to original | ||
| // sequence expression. | ||
|
|
||
| // *e = *s.exprs.pop().unwrap(); |
There was a problem hiding this comment.
You can
-
assign the span of the node with
PUREcomment to the emitted node -
Accept
C: Commentsor&dyn Commentsand callmove_leading
|
I'll take on this |
kdy1
force-pushed
the
branch-simplify-pure
branch
from
9f9f1ea
to
898f70e
Compare
kdy1
added a commit
that referenced
this pull request
Jul 6, 2024
**Description:** This is required for #8907
kdy1
force-pushed
the
branch-simplify-pure
branch
from
8d526b5
to
2e76dd1
Compare
kdy1
changed the title
SeqExpr
kdy1
approved these changes
Jul 31, 2024
CodSpeed Performance ReportMerging #8907 will improve performances by 8.8%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code like
/*#__PURE__*/ (0, forwardRef)(Foo);, thedead_branch_removerpass will simplify this toforwardRef(Foo)and remove thePUREannotation which might be used in later passes. I added a test to show this, and commented out the line that causes it. However I'm not quite sure how to fix it.I guess the comment is attached to the original sequence expression which was removed. So we need to move the comment to the resulting expression somehow, or maybe change the span of the expression to match the old one.
I tried passing in the comments to this pass so I could move it, but it was a bit hard because of the
Parallelimplementation that would require the comments to beSend + Sync.Any suggestions on the best approach here?