fix(es/minifier): Preserve flags while dropping elements of SeqExpr
#8907
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In code like
/*#__PURE__*/ (0, forwardRef)(Foo);
, thedead_branch_remover
pass will simplify this toforwardRef(Foo)
and remove thePURE
annotation which might be used in later passes. I added a test to show this, and commented out the line that causes it. However I'm not quite sure how to fix it.I guess the comment is attached to the original sequence expression which was removed. So we need to move the comment to the resulting expression somehow, or maybe change the span of the expression to match the old one.
I tried passing in the comments to this pass so I could move it, but it was a bit hard because of the
Parallel
implementation that would require the comments to beSend + Sync
.Any suggestions on the best approach here?