fix(es/fixer): Wrap in expr in for-in head
#9209
Conversation
CodSpeed Performance ReportMerging #9209 will not alter performanceComparing Summary
|
| @@ -0,0 +1,72 @@ | |||
| for(var a = (b in c) in {}); | |||
| for(var a = 1 || (b in c) in {}); | |||
| for(var a = 1 + (2 || (b in c)) in {}); | |||
There was a problem hiding this comment.
We have some false positives. It is no longer necessary to add parentheses around the in expression that is already in parentheses.
We need to check the in expressions from the outside in. But currently, the wrap calls are from the inside out, which cannot be completed in a single pass.
Do you have any thoughts? @kdy1
There was a problem hiding this comment.
Can we proceed with some false positives for now and refactor them outside? If you prefer, rewriting the fixer to work outside in is also fine.
There was a problem hiding this comment.
I plan to leave a TODO for now, as this is a very rare edge case and has no negative impact.
kdy1
changed the title
in expr in for-in headin expr in for-in head
Related issue (if exists):