Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@swc/types): tsc build file ignored by npm #9754

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

jeasonstudio
Copy link
Contributor

Description:
JS and DTS files in @swc/types are automatically ignored by npm. Add the files attribute in package.json to make it work.

Here's the result of npm publish --dry-run:

> @swc/types@0.1.16 prepublishOnly
> yarn build

npm notice
npm notice 📦  @swc/types@0.1.16
npm notice Tarball Contents
npm notice 10.8kB LICENSE
npm notice 219B README.md
npm notice 2.6kB assumptions.d.ts
npm notice 77B assumptions.js
npm notice 61.8kB index.d.ts
npm notice 77B index.js
npm notice 902B package.json
npm notice Tarball Details
npm notice name: @swc/types
npm notice version: 0.1.16
npm notice filename: swc-types-0.1.16.tgz
npm notice package size: 18.5 kB
npm notice unpacked size: 76.6 kB
npm notice shasum: 0740c566a7f6eca97d02d03a0f4a059b0b5903e7
npm notice integrity: sha512-pcVB4Cnv1hS/s[...]quwePgoVn6Lmg==
npm notice total files: 7

BREAKING CHANGE:
Nothing.

Related issue (if exists):

@jeasonstudio jeasonstudio requested a review from a team as a code owner November 21, 2024 06:27
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 14c240d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jeasonstudio
Copy link
Contributor Author

Related to #9753

Copy link

Report too large to display inline

View full report↗︎

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #9754 will degrade performances by 4.21%

Comparing jeasonstudio:fix-swc-types-build-not-work (14c240d) with main (cd4321c)

Summary

❌ 1 regressions
✅ 193 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main jeasonstudio:fix-swc-types-build-not-work Change
es/full/parser 1.5 ms 1.5 ms -4.21%

@kdy1 kdy1 merged commit 14a5c1e into swc-project:main Nov 21, 2024
3 checks passed
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants