-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing periods in ep 05 #1014
Add missing periods in ep 05 #1014
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1014 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-08-26 09:49:45 +0000 |
Thank you for catching the missing periods and for taking the time to submit this PR. I have to point out that the first change would render as |
Makes sense, thank you for the feedback. If the other edit is to be applied, is there any further action needed on my part? |
I've updated it myself. |
Thank you. |
Auto-generated via {sandpaper} Source : f5732ae Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-09-29 16:51:10 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c4c728 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-09-29 16:50:33 +0000 Message : Merge pull request #1014 from tomeknd/fix/ep-05-typo-and-markdown Add missing periods in ep 05
Auto-generated via {sandpaper} Source : f5732ae Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-09-29 16:51:10 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c4c728 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-09-29 16:50:33 +0000 Message : Merge pull request #1014 from tomeknd/fix/ep-05-typo-and-markdown Add missing periods in ep 05
This is my first ever PR, so any feedback appreciated if applicable. Thank you for maintaining this awesome project!