Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing periods in ep 05 #1014

Merged
merged 4 commits into from
Sep 29, 2024

Conversation

tomeknd
Copy link
Contributor

@tomeknd tomeknd commented Aug 25, 2024

This is my first ever PR, so any feedback appreciated if applicable. Thank you for maintaining this awesome project!

Copy link

github-actions bot commented Aug 25, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1014

The following changes were observed in the rendered markdown documents:

 05-history.md | 2 +-
 md5sum.txt    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-08-26 09:49:45 +0000

@martinosorb
Copy link
Contributor

Thank you for catching the missing periods and for taking the time to submit this PR. I have to point out that the first change would render as git restore .. which looks an awful lot like git restore .. which is a different command (referring to the parent directory .. rather than the current directory .). So I would avoid the period there to avoid confusion...

@tomeknd
Copy link
Contributor Author

tomeknd commented Aug 25, 2024

Makes sense, thank you for the feedback. If the other edit is to be applied, is there any further action needed on my part?

@martinosorb
Copy link
Contributor

I've updated it myself.
I will not merge for a while because we are waiting for a larger merge which I don't want to conflict with this. Thank you.

github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
@tomeknd
Copy link
Contributor Author

tomeknd commented Aug 26, 2024

Thank you.

@martinosorb martinosorb merged commit 4c4c728 into swcarpentry:main Sep 29, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 29, 2024
Auto-generated via {sandpaper}
Source  : 4c4c728
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-09-29 16:50:33 +0000
Message : Merge pull request #1014 from tomeknd/fix/ep-05-typo-and-markdown

Add missing periods in ep 05
github-actions bot pushed a commit that referenced this pull request Sep 29, 2024
Auto-generated via {sandpaper}
Source  : f5732ae
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-29 16:51:10 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4c4c728
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-09-29 16:50:33 +0000
Message : Merge pull request #1014 from tomeknd/fix/ep-05-typo-and-markdown

Add missing periods in ep 05
github-actions bot pushed a commit that referenced this pull request Oct 1, 2024
Auto-generated via {sandpaper}
Source  : f5732ae
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-09-29 16:51:10 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 4c4c728
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-09-29 16:50:33 +0000
Message : Merge pull request #1014 from tomeknd/fix/ep-05-typo-and-markdown

Add missing periods in ep 05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants