Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentence in quiz Understanding Workflow and History #1052

Conversation

JoKeyser
Copy link
Contributor

Hi, I caught another small problem while reading the lesson.

Let me offer an armchair diagnosis: I believe this error was made more likely because sentences are split across multiple lines, and at least to my eyes, without a consistent rule when to split lines.
(Personally, I would suggest one-line-per-sentence, as each sentence is one unit of thought.)

Copy link

github-actions bot commented Nov 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-1052

The following changes were observed in the rendered markdown documents:

 05-history.md | 2 +-
 md5sum.txt    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-11-18 14:31:33 +0000

github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
@martinosorb
Copy link
Contributor

That seems to be the explanation, thanks again.

@martinosorb martinosorb merged commit 4c7a476 into swcarpentry:main Nov 19, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : 4c7a476
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-11-19 17:35:24 +0000
Message : Merge pull request #1052 from JoKeyser/fix-sentence-in-history-quiz-understanding-workflow-and-history

Fix sentence in quiz Understanding Workflow and History
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Auto-generated via `{sandpaper}`
Source  : 8fc2984
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-11-19 17:36:18 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 4c7a476
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-11-19 17:35:24 +0000
Message : Merge pull request #1052 from JoKeyser/fix-sentence-in-history-quiz-understanding-workflow-and-history

Fix sentence in quiz Understanding Workflow and History
github-actions bot pushed a commit that referenced this pull request Nov 26, 2024
Auto-generated via `{sandpaper}`
Source  : 8fc2984
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-11-19 17:36:18 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 4c7a476
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2024-11-19 17:35:24 +0000
Message : Merge pull request #1052 from JoKeyser/fix-sentence-in-history-quiz-understanding-workflow-and-history

Fix sentence in quiz Understanding Workflow and History
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants