-
-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to new private email pattern from GitHub, explain where to fin… #987
Conversation
…d the no-reply mail.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/git-novice/compare/md-outputs..md-outputs-PR-987 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-05-02 07:45:01 +0000 |
Thanks for the PR, I agree that the phrasing was confusing. I only changed your comma to a full stop for grammatical nicety. |
Auto-generated via {sandpaper} Source : 73646d0 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-05-28 12:01:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3221e00 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-05-28 12:00:11 +0000 Message : Merge pull request #987 from BalthasarSchachtner/main Update to new private email pattern from GitHub, explain where to fin…
Auto-generated via {sandpaper} Source : 73646d0 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-05-28 12:01:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3221e00 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-05-28 12:00:11 +0000 Message : Merge pull request #987 from BalthasarSchachtner/main Update to new private email pattern from GitHub, explain where to fin…
Auto-generated via {sandpaper} Source : 73646d0 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-05-28 12:01:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3221e00 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-05-28 12:00:11 +0000 Message : Merge pull request #987 from BalthasarSchachtner/main Update to new private email pattern from GitHub, explain where to fin…
Auto-generated via {sandpaper} Source : 73646d0 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-05-28 12:01:17 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 3221e00 Branch : main Author : Martino Sorbaro <martinosorb@users.noreply.github.com> Time : 2024-05-28 12:00:11 +0000 Message : Merge pull request #987 from BalthasarSchachtner/main Update to new private email pattern from GitHub, explain where to fin…
…d the no-reply mail.
When going through the episode setup, I found a bit confusing that there is written
With the example after this part of the sentence it becomes clear what is meant, but I might be inclined to put my private mail there and expose it.
Next I saw, that the pattern for these no-reply mails seems to have changed in 2017 and now has the form
ID+USERNAME@users.noreply.github.com
: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/setting-your-commit-email-address#about-commit-email-addressesI tried to address both of these points in this pull request. Due to the
ID
in the no-reply email, I think it now needs to be looked up and cannot be formed from the user name, that's why I included the link, let me know if this works for you.