Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reliance on implicit df behavior, #819 #866

Merged

Conversation

brshallo
Copy link
Contributor

Closes #819

The example I changed relied on implicit behavior of dataframes (which is often better to avoid and doesn't work on tibbles) so I made a slight change to the example that results in the same output but doesn't rely on the implicit dataframe behavior of converting a one column dataframe into a vector.

@github-actions
Copy link

github-actions bot commented Sep 11, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-866

The following changes were observed in the rendered markdown documents:

 13-dplyr.md | 6 +++---
 md5sum.txt  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-15 23:52:51 +0000

@matthieu-bruneaux
Copy link
Contributor

Thank you for your contribution @brshallo! This is very helpful.

github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
@matthieu-bruneaux matthieu-bruneaux merged commit d026135 into swcarpentry:main Nov 15, 2023
4 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Auto-generated via {sandpaper}
Source  : d026135
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2023-11-15 23:54:03 +0000
Message : Merge pull request #866 from brshallo/brshallo-implicit-df-replace

Remove reliance on implicit df behavior, #819
github-actions bot pushed a commit that referenced this pull request Nov 15, 2023
Auto-generated via {sandpaper}
Source  : c179768
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-11-15 23:55:25 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d026135
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2023-11-15 23:54:03 +0000
Message : Merge pull request #866 from brshallo/brshallo-implicit-df-replace

Remove reliance on implicit df behavior, #819
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
Auto-generated via {sandpaper}
Source  : c179768
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-11-15 23:55:25 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : d026135
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2023-11-15 23:54:03 +0000
Message : Merge pull request #866 from brshallo/brshallo-implicit-df-replace

Remove reliance on implicit df behavior, #819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants