Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unwanted R code #877

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

SarithaKodikara
Copy link
Contributor

In the episode exploring data frames (https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html), renaming row names is unnecessary as R re-names them sequentially. So, in the section 'Append to a data frame', the following code snippet can be removed.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Closes #873

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

In the episode exploring data frames (https://swcarpentry.github.io/r-novice-gapminder/05-data-structures-part2.html), renaming row names is unnecessary as R re-names them sequentially. So, in the section 'Append to a data frame', the following code snippet can be removed.
Copy link

github-actions bot commented Nov 21, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-877

The following changes were observed in the rendered markdown documents:

 05-data-structures-part2.md | 23 +----------------------
 md5sum.txt                  |  2 +-
 2 files changed, 2 insertions(+), 23 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-21 14:41:36 +0000

github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
@matthieu-bruneaux
Copy link
Contributor

Thank you very much for your contribution @SarithaKodikara! This is very helpful to keep the lesson material up to date.

I took the liberty to remove the mention of rownames() in the lesson key points to have them consistent with your changes.

@matthieu-bruneaux matthieu-bruneaux merged commit 713a568 into swcarpentry:main Nov 21, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : 713a568
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2023-11-21 14:51:35 +0000
Message : Merge pull request #877 from SarithaKodikara/main

Remove unwanted R code
github-actions bot pushed a commit that referenced this pull request Nov 21, 2023
Auto-generated via {sandpaper}
Source  : ab0b57a
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-11-21 14:52:58 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 713a568
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2023-11-21 14:51:35 +0000
Message : Merge pull request #877 from SarithaKodikara/main

Remove unwanted R code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove code that is not needed
2 participants