-
-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace size with linewidth #890
Conversation
Replace `size` with `linewidth` for `geom_smooth()` example. Using `size` for lines was deprecated per this error message: > > ggplot(data=gapminder, > + mapping=aes(x=gdpPercap, > + y=lifeExp)) + > + geom_point(alpha=0.5) + > + scale_x_log10() + > + geom_smooth(method='lm', size=1.5) > `geom_smooth()` using formula = 'y ~ x' > Warning message: > Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0. > ℹ Please use `linewidth` instead. > This warning is displayed once every 8 hours. > Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated. Change throughout the lesson and additionally: 1. Adjust language in explanations to match 2. Add hint to challenge clarifying size is point equivalent of linewidth. 3. Add some additional explanation of difference between aesthetics with vs without mappings.
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-890 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2024-05-16 13:15:02 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ndporter - thanks so much for addressing this issue.
The changes look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-generated via {sandpaper} Source : a3977d6 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-06-12 19:45:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c784b32 Branch : main Author : Matthieu Bruneaux <matthieu.bruneaux@gmail.com> Time : 2024-06-12 19:44:06 +0000 Message : Merge pull request #890 from ndporter/patch-2 Replace size with linewidth for geom_smooth()
Auto-generated via {sandpaper} Source : a3977d6 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-06-12 19:45:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c784b32 Branch : main Author : Matthieu Bruneaux <matthieu.bruneaux@gmail.com> Time : 2024-06-12 19:44:06 +0000 Message : Merge pull request #890 from ndporter/patch-2 Replace size with linewidth for geom_smooth()
Auto-generated via {sandpaper} Source : c784b32 Branch : main Author : Matthieu Bruneaux <matthieu.bruneaux@gmail.com> Time : 2024-06-12 19:44:06 +0000 Message : Merge pull request swcarpentry#890 from ndporter/patch-2 Replace size with linewidth for geom_smooth()
Auto-generated via {sandpaper} Source : 1703521 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-06-20 14:54:15 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c784b32 Branch : main Author : Matthieu Bruneaux <matthieu.bruneaux@gmail.com> Time : 2024-06-12 19:44:06 +0000 Message : Merge pull request swcarpentry#890 from ndporter/patch-2 Replace size with linewidth for geom_smooth()
Auto-generated via {sandpaper} Source : a3977d6 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2024-06-12 19:45:26 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : c784b32 Branch : main Author : Matthieu Bruneaux <matthieu.bruneaux@gmail.com> Time : 2024-06-12 19:44:06 +0000 Message : Merge pull request #890 from ndporter/patch-2 Replace size with linewidth for geom_smooth()
Replace
size
withlinewidth
forgeom_smooth()
example. Usingsize
for lines was deprecated per this error message:Change throughout the lesson and additionally:
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
If any relevant discussions have taken place elsewhere, please provide links to these.
For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.
Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.