Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace size with linewidth #890

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

ndporter
Copy link
Contributor

Replace size with linewidth for geom_smooth() example. Using size for lines was deprecated per this error message:

> ggplot(data=gapminder,
+        mapping=aes(x=gdpPercap,
+                    y=lifeExp)) +
+   geom_point(alpha=0.5) +
+   scale_x_log10() +
+   geom_smooth(method='lm', size=1.5)
`geom_smooth()` using formula = 'y ~ x'
Warning message:
Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
ℹ Please use `linewidth` instead.
This warning is displayed once every 8 hours.
Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated. 

Change throughout the lesson and additionally:

  1. Adjust language in explanations to match
  2. Add hint to challenge clarifying size is point equivalent of linewidth.
  3. Add some additional explanation of difference between aesthetics with vs without mappings.

If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.

Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.

If any relevant discussions have taken place elsewhere, please provide links to these.

For more guidance on how to contribute changes to a Carpentries project, please review the Contributing Guide and Code of Conduct.

Please keep in mind that lesson Maintainers are volunteers and it may be some time before they can respond to your contribution. Although not all contributions can be incorporated into the lesson materials, we appreciate your time and effort to improve the curriculum. If you have any questions about the lesson maintenance process or would like to volunteer your time as a contribution reviewer, please contact The Carpentries Team at team@carpentries.org.

Replace `size` with `linewidth` for `geom_smooth()` example. Using `size` for lines was deprecated per this error message:

> > ggplot(data=gapminder,
> +        mapping=aes(x=gdpPercap,
> +                    y=lifeExp)) +
> +   geom_point(alpha=0.5) +
> +   scale_x_log10() +
> +   geom_smooth(method='lm', size=1.5)
> `geom_smooth()` using formula = 'y ~ x'
> Warning message:
> Using `size` aesthetic for lines was deprecated in ggplot2 3.4.0.
> ℹ Please use `linewidth` instead.
> This warning is displayed once every 8 hours.
> Call `lifecycle::last_lifecycle_warnings()` to see where this warning was generated. 

Change throughout the lesson and additionally:
1. Adjust language in explanations to match
2. Add hint to challenge clarifying size is point equivalent of linewidth.
3. Add some additional explanation of difference between aesthetics with vs without mappings.
Copy link

github-actions bot commented May 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/r-novice-gapminder/compare/md-outputs..md-outputs-PR-890

The following changes were observed in the rendered markdown documents:

 01-rstudio-intro.md |    2 +-
 02-project-intro.md |    2 +-
 03-seeking-help.md  |    6 +-
 08-plot-ggplot2.md  |   23 +-
 config.yaml (gone)  |   95 -----
 md5sum.txt          |   50 +--
 renv.lock (gone)    | 1021 ---------------------------------------------------
 7 files changed, 37 insertions(+), 1162 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-16 13:15:02 +0000

github-actions bot pushed a commit that referenced this pull request May 16, 2024
Copy link
Contributor

@skanwal skanwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ndporter - thanks so much for addressing this issue.
The changes look good to me.

Copy link
Contributor

@matthieu-bruneaux matthieu-bruneaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ndporter and @skanwal! This looks good to me too.

@matthieu-bruneaux matthieu-bruneaux merged commit c784b32 into swcarpentry:main Jun 12, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request #890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
github-actions bot pushed a commit that referenced this pull request Jun 12, 2024
Auto-generated via {sandpaper}
Source  : a3977d6
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-12 19:45:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request #890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
github-actions bot pushed a commit that referenced this pull request Jun 18, 2024
Auto-generated via {sandpaper}
Source  : a3977d6
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-12 19:45:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request #890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
github-actions bot pushed a commit to umn-dash/r-novice-gapminder that referenced this pull request Jun 20, 2024
Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request swcarpentry#890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
github-actions bot pushed a commit to umn-dash/r-novice-gapminder that referenced this pull request Jun 20, 2024
Auto-generated via {sandpaper}
Source  : 1703521
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-20 14:54:15 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request swcarpentry#890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
github-actions bot pushed a commit that referenced this pull request Jun 25, 2024
Auto-generated via {sandpaper}
Source  : a3977d6
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-06-12 19:45:26 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : c784b32
Branch  : main
Author  : Matthieu Bruneaux <matthieu.bruneaux@gmail.com>
Time    : 2024-06-12 19:44:06 +0000
Message : Merge pull request #890 from ndporter/patch-2

Replace size with linewidth for geom_smooth()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants