Skip to content

Commit

Permalink
Remove the last remaining NIOAtomic (#607)
Browse files Browse the repository at this point in the history
Motivation

Warnings aren't great, and NIOAtomic is deprecated.

Modifications

Replace the last use of NIOAtomic with ManagedAtomic.

Result

Fewer warnings
Fixes #606
  • Loading branch information
Lukasa authored Aug 3, 2022
1 parent 2adca4b commit 0527bbb
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions Sources/AsyncHTTPClient/HTTPClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
//
//===----------------------------------------------------------------------===//

import Atomics
import Foundation
import Logging
import NIOConcurrencyHelpers
Expand All @@ -36,7 +37,7 @@ extension Logger {
}
}

let globalRequestID = NIOAtomic<Int>.makeAtomic(value: 0)
let globalRequestID = ManagedAtomic(0)

/// HTTPClient class provides API for request execution.
///
Expand Down Expand Up @@ -541,7 +542,7 @@ public class HTTPClient {
logger originalLogger: Logger?,
redirectState: RedirectState?
) -> Task<Delegate.Response> {
let logger = (originalLogger ?? HTTPClient.loggingDisabled).attachingRequestInformation(request, requestID: globalRequestID.add(1))
let logger = (originalLogger ?? HTTPClient.loggingDisabled).attachingRequestInformation(request, requestID: globalRequestID.wrappingIncrementThenLoad(ordering: .relaxed))
let taskEL: EventLoop
switch eventLoopPreference.preference {
case .indifferent:
Expand Down

0 comments on commit 0527bbb

Please sign in to comment.