Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a new 'colored' Backtrace format #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natinusala
Copy link

This allows customizing the printed backtrace format, and separates backtrace formatting (platform agnostic) and printing (platform specific).

The current format is now called full and I made a new one called colored (I'm not quite happy with the name, I'm open to suggestions) with colors and a newline between the function name and file. It's easier on the eyes when reading on a small integrated terminal. It also removes the top 4 stack entries that are mostly irrelevant (since they belong to either Backtrace or libc / Windows CRT).

This has been tested and works fine on both Linux and Windows.

@swift-server-bot
Copy link

Can one of the admins verify this patch?

9 similar comments
@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@swift-server-bot
Copy link

Can one of the admins verify this patch?

@ktoso
Copy link
Contributor

ktoso commented Jan 4, 2023

Hi there,
we're currently investing into "solving backtraces" in the swift runtime itself, some news here: https://forums.swift.org/t/backtraces-in-swift/61736

So I don't think we necessarily want to be adding much more functionality in this project, rather, we're slowly sunsetting it.

Perhaps such format improvements are something that can be brought up in the thread I linked, to make sure the format of the official output is as nice as you'd hope it to be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants