Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Sorbet and basic type coverage #6

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Adds Sorbet and basic type coverage #6

merged 6 commits into from
Jul 17, 2023

Conversation

swiknaba
Copy link
Owner

@swiknaba swiknaba commented Jul 17, 2023 •
edited
Loading

  • adds bin/lint
  • adds Sorbet
  • type most of the codebase (WIP)
  • run type checks on CI
  • broke out rubocop to its own workflow on CI since it seems to hang up sometimes

@swiknaba swiknaba requested a review from morozRed July 17, 2023 15:55
morozRed
morozRed previously approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@morozRed morozRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@swiknaba swiknaba merged commit b025b2f into master Jul 17, 2023
13 checks passed
@swiknaba swiknaba deleted the lud/sorbet branch July 17, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morozRed morozRed morozRed left review comments

Assignees

@morozRed morozRed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swiknaba @morozRed