Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for ignoring external origins #121

Merged
merged 3 commits into from
Jan 27, 2024
Merged

Conversation

daun
Copy link
Member

@daun daun commented Jan 26, 2024

Description

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included

@daun daun requested a review from a team January 26, 2024 16:10
Copy link

Playwright test results

passed  76 passed
skipped  4 skipped

Details

stats  80 tests across 8 suites
duration  1 minute, 12 seconds
commit  aeb3e58

Skipped tests

chromium → preload-plugin.spec.ts → active links → preloads links on touchstart
firefox → preload-plugin.spec.ts → active links → preloads links on touchstart
webkit → preload-plugin.spec.ts → active links → preloads links on touchstart
ios → preload-plugin.spec.ts → active links → preloads links on hover

Copy link
Member

@hirasso hirasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🍰

@daun daun merged commit ebf9010 into master Jan 27, 2024
2 checks passed
@daun daun deleted the functional-tests branch January 27, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants