fix: don't wrongly abort preload fetch requests

[hirasso]

The problem

Currently, all preload requests after the first page:view are being exited early. The reason for this is that swup.fetchPage falls back to swup's internal visit object if we don't provide a custom visit to it. It then calls the hook fetch:request that exits early if the visit is already done.

The solution

Pass the temporary visit from performPreload along in the FetchOptions for fetchPage.

Future

• should we make the visit a required FetchOption so that we don't run into this again?
• should we make FetchOptions.visit public?

I'd like to merge this as soon as possible, we can discuss possible improvements later.

Checks

• The PR is submitted to the master branch
• The code was linted before pushing (npm run lint)
• All tests are passing (npm run test)

[github-actions]

Playwright test results

 88 passed
 4 skipped

Details

 92 tests across 8 suites
 1 minute, 25 seconds
 a0422a6

Skipped tests

chromium → preload-plugin.spec.ts → active links → preloads links on touchstart
firefox → preload-plugin.spec.ts → active links → preloads links on touchstart
webkit → preload-plugin.spec.ts → active links → preloads links on touchstart
ios → preload-plugin.spec.ts → active links → preloads links on hover

[daun]

Nice! I'd tend to answer no to both questions – the FetchOptions interface is also part of the public API of navigate() and I'd rather keep that clean. We might refactor the whole thing though because currently it's a bit messy 🤠