* layers/+spacemacs/spacemacs-defaults/funcs.el: Enhance copying file path for dired-mode #16766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcc32
requested changes
Dec 29, 2024
… path for dired-mode
sunlin7
force-pushed
the
copy-file-path-enhance
branch
from
eb44da2 to
bba77f4
Compare
|
@bcc32 Thanks for the comments, new changes pushed, please help review again. |
|
Pushed some small tweaks, to (1) avoid raising a |
|
@bcc32 Thank you for the improvement, and I had tried the last one on my local, they work perfect ! Thanks |
bcc32
approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pressing
SPC f y yon adired-modebuffer will get an error.This PR enhances the users experience by support copying file path on a
dired-modebuffer (SPC f y yin a dired buffer).