Add evil-fringe-mark to +spacemacs/spacemacs-evil #16770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you try it with |
fnussbaum
reviewed
Dec 31, 2024
| (defun spacemacs-evil/init-evil-fringe-mark () | ||
| (use-package evil-fringe-mark | ||
| :config | ||
| (setq-default evil-fringe-mark-show-special t) |
There was a problem hiding this comment.
I think it would be better to set options in the :init or :custom block. It makes them easier to override by users when the package is deferred.
| (use-package evil-fringe-mark | ||
| :config | ||
| (setq-default evil-fringe-mark-show-special t) | ||
| (global-evil-fringe-mark-mode))) |
There was a problem hiding this comment.
If we add this package, it should be deferred, and the mode should not be enabled by default. It would make sense to add a toggle as for evil-visual-mark-mode, SPC t ' seems logical as a key binding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the evil-fringe-mark package.
I configured it to display both user and special marks globally.
Thanks