Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* layers/+spacemacs/spacemacs-defaults/packages.el: Avoid loading outline-mode #16772

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

sunlin7
Copy link
Contributor

@sunlin7 sunlin7 commented Dec 31, 2024

Hi @fnussbaum I noticed two lines

(require 'outline)
(add-hook 'ediff-prepare-buffer-hook #'outline-show-all)

can be improved to no-requiring the outline package for better performance.

Please help review the changes, thank you!

Copy link
Collaborator

@bcc32 bcc32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Just two small nits here.

layers/+spacemacs/spacemacs-defaults/packages.el Outdated Show resolved Hide resolved
layers/+spacemacs/spacemacs-defaults/packages.el Outdated Show resolved Hide resolved
@sunlin7 sunlin7 force-pushed the ediff-avoid-loading-outline branch from 2994473 to e737eb2 Compare January 1, 2025 01:04
@sunlin7 sunlin7 force-pushed the ediff-avoid-loading-outline branch from e737eb2 to 0aae747 Compare January 1, 2025 16:16
@fnussbaum fnussbaum merged commit 341ba9f into syl20bnr:develop Jan 3, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants