Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto darkmode is overwritten by light mode #405

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Fix auto darkmode is overwritten by light mode #405

merged 1 commit into from
Nov 9, 2023

Conversation

MG-5
Copy link
Contributor

@MG-5 MG-5 commented Nov 7, 2023

Fix #403

@soullivaneuh
Copy link
Contributor

soullivaneuh commented Nov 7, 2023 •
edited
Loading

It does work, but we still have the light mode first for a second at the first load of the page.

Do we have any possibility to have the dark theme being set at the very beginning? 🤔

@soullivaneuh soullivaneuh mentioned this pull request Nov 7, 2023
Merged
@soullivaneuh
Copy link
Contributor

It does work, but we still have the light mode first for a second at the first load of the page.

Do we have any possibility to have the dark theme being set at the very beginning? 🤔

@MG-5 I did find a solution for that, please see #406 based from your branch. 👍

@sylhare
Copy link
Owner

sylhare commented Nov 9, 2023

Let me review both PR 👍

@sylhare sylhare merged commit 31665b6 into sylhare:master Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto darkmode does not work
3 participants
@MG-5 @soullivaneuh @sylhare