MNT Fix some unit tests (#415)

symbiote · Aug 27, 2024 · 4bbfa9d · 4bbfa9d
1 parent c3ddeb3
commit 4bbfa9d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/tests/GridFieldEditableColumnsTest.php b/tests/GridFieldEditableColumnsTest.php
@@ -5,8 +5,6 @@
 use Symbiote\GridFieldExtensions\Tests\Stub\TestController;
 use Symbiote\GridFieldExtensions\Tests\Stub\StubUnorderable;
 use Symbiote\GridFieldExtensions\GridFieldEditableColumns;
-use SilverStripe\ORM\FieldType\DBHTMLText;
-use SilverStripe\Forms\TextField;
 use SilverStripe\Forms\GridField\GridField;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\FieldList;
@@ -47,10 +45,9 @@ public function testProvidesEditableFieldsInColumns()
         $record->setCanEdit(true);
         $column = $component->getColumnContent($grid, $record, 'Title');
 
-        $this->assertInstanceOf(DBHTMLText::class, $column);
         $this->assertMatchesRegularExpression(
             '/<input type="text" name="TestGridField\[GridFieldEditableColumns\]\[100\]\[Title\]" value="foo"[^>]*>/',
-            $column->getValue()
+            $column
         );
     }
 
@@ -63,10 +60,9 @@ public function testProvidesReadonlyColumnsForNoneditableRecords()
         $record->setCanEdit(false);
         $column = $component->getColumnContent($grid, $record, 'Title');
 
-        $this->assertInstanceOf(DBHTMLText::class, $column);
         $this->assertMatchesRegularExpression(
             '/<span[^>]*>\s*testval\s*<\/span>/',
-            $column->getValue()
+            $column
         );
     }
 
@@ -85,10 +81,9 @@ public function testProvidesReadonlyColumnsForReadonlyGrids()
 
         $column = $component->getColumnContent($grid, $record, 'Title');
 
-        $this->assertInstanceOf(DBHTMLText::class, $column);
         $this->assertMatchesRegularExpression(
             '/<span[^>]*>\s*testval\s*<\/span>/',
-            $column->getValue()
+            $column
         );
     }
 }
diff --git a/tests/OrderableRowsThroughVersionedTest.php b/tests/OrderableRowsThroughVersionedTest.php
@@ -33,7 +33,7 @@ class OrderableRowsThroughVersionedTest extends SapphireTest
     protected function setUp(): void
     {
         parent::setUp();
-        $this->orignalReadingMode = Versioned::get_reading_mode();
+        $this->originalReadingMode = Versioned::get_reading_mode();
     }
 
     protected function tearDown(): void