Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Don't use keyword "self" #410

Merged
merged 1 commit into from
Aug 1, 2024
Merged

ENH Don't use keyword "self" #410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions src/GridFieldNestedForm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ class GridFieldNestedForm extends AbstractGridFieldComponent implements
GridField_DataManipulator
{
use Configurable, GridFieldStateAware;

/**
* The key used in the post data to identify nested form data
*/
Expand All @@ -55,7 +55,7 @@ class GridFieldNestedForm extends AbstractGridFieldComponent implements
* The default max nesting level. Nesting further than this will throw an exception.
*/
private static int $default_max_nesting_level = 10;

private string $name;

private bool $expandNested = false;
Expand All @@ -74,12 +74,12 @@ class GridFieldNestedForm extends AbstractGridFieldComponent implements
private $canExpandCallback = null;

private int $maxNestingLevel = 0;

public function __construct($name = 'NestedForm')
{
$this->name = $name;
}

/**
* Get the grid field that this component is attached to
*/
Expand All @@ -95,7 +95,7 @@ public function getRelationName(): string
{
return $this->relationName;
}

/**
* Set the relation name to use for the nested grid fields
*/
Expand All @@ -121,7 +121,7 @@ public function setInlineEditable(bool $editable): static
$this->inlineEditable = $editable;
return $this;
}

/**
* Set whether the nested grid fields should be expanded by default
*/
Expand Down Expand Up @@ -255,7 +255,7 @@ public function getColumnContent($gridField, $record, $columnName)
])->renderWith('Symbiote\GridFieldExtensions\GridFieldNestedForm');
}
}

public function getURLHandlers($gridField)
{
return [
Expand Down Expand Up @@ -349,7 +349,7 @@ public function handleMoveToParent(GridField $gridField, $request): string
}
return $gridField->FieldHolder();
}

/**
* Handle the request to show a nested item
*/
Expand Down Expand Up @@ -424,7 +424,7 @@ public function toggleNestedItem(
$stateRelation = $className.'-'.$record->ID.'-'.$this->getRelationName();
$state->$stateRelation = (int)$request->getVar('toggle');
}

/**
* Get the link for the nested grid field
*/
Expand All @@ -444,10 +444,10 @@ public function ToggleLink($action = null): string
$manager = $this->getStateManager();
return $manager->addStateToURL($this->gridField, $link);
}

public function handleSave(GridField $gridField, DataObjectInterface $record)
{
$postKey = self::POST_KEY;
$postKey = GridFieldNestedForm::POST_KEY;
$value = $gridField->Value();
if (isset($value['GridState']) && $value['GridState']) {
// set grid state from value, to store open/closed toggle state for nested forms
Expand Down
Loading