Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove bad code #6

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

🔥 Remove bad code #6

wants to merge 3 commits into from

Conversation

ldidry
Copy link
Contributor

@ldidry ldidry commented Jul 16, 2020

@ldidry ldidry added the enhancement New feature or request label Jul 16, 2020
@ldidry ldidry added this to the 2.6.20 milestone Jul 16, 2020
@ldidry ldidry requested review from racke, dverdin and ikedas July 16, 2020 11:57
ldidry
ldidry commented Jul 16, 2020
View reviewed changes
lib/MHonArc/CharEnt/AppleArabic.pm
@@ -1,4 +1,7 @@
package MHonArc::CharEnt::AppleArabic;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously, Github have some troubles with the characters in some files 🤷

If you checkout my branch and do git diff a98d78e..e4b5f4a, it should be displayed correctly (here, the first line is package MHonArc::UTF8::AppleArabic;), except for characters that you don't have the font to display.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways we may let homemade codecs retire: Encode module became standard way as of Perl 5.8. I'd like to work for this improvement in some day.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikedas sounds good 👍

@ldidry ldidry changed the title Remove bad code 🔥 Remove bad code Jul 17, 2020
dverdin
dverdin approved these changes Jul 20, 2020
View reviewed changes
Copy link

@dverdin dverdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only approve the usage of strict and warnings.
So I see no problem with this PR. I may certainly break things, but baring any way to test, we need to roll with it.
Thanks Luc!

@ldidry ldidry force-pushed the remove-bad-code branch from e4b5f4a to 5a8a28e Compare July 20, 2020 10:39
@ldidry ldidry mentioned this pull request Jul 20, 2020
Merged
ikedas
ikedas approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okey, I confirmed it correctly compile.

racke
racke approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@racke racke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ldidry ldidry force-pushed the remove-bad-code branch from 5a8a28e to 6879de4 Compare July 27, 2020 08:16
@ikedas
Merge branch 'develop' into remove-bad-code
b7ba8aa 
Conflicts:
	lib/MHonArc/Char.pm
	lib/MHonArc/Char/JP.pm
	lib/MHonArc/Char/KR.pm
	lib/MHonArc/CharEnt/AppleArabic.pm
	lib/MHonArc/CharEnt/AppleCenteuro.pm
	lib/MHonArc/CharEnt/AppleCroatian.pm
	lib/MHonArc/CharEnt/AppleCyrillic.pm
	lib/MHonArc/CharEnt/AppleGreek.pm
	lib/MHonArc/CharEnt/AppleHebrew.pm
	lib/MHonArc/CharEnt/AppleIceland.pm
	lib/MHonArc/CharEnt/AppleRoman.pm
	lib/MHonArc/CharEnt/AppleRomanian.pm
	lib/MHonArc/CharEnt/AppleThai.pm
	lib/MHonArc/CharEnt/AppleTurkish.pm
	lib/MHonArc/CharEnt/BIG5_ETEN.pm
	lib/MHonArc/CharEnt/BIG5_HKSCS.pm
	lib/MHonArc/CharEnt/CP1250.pm
	lib/MHonArc/CharEnt/CP1251.pm
	lib/MHonArc/CharEnt/CP1252.pm
	lib/MHonArc/CharEnt/CP1253.pm
	lib/MHonArc/CharEnt/CP1254.pm
	lib/MHonArc/CharEnt/CP1255.pm
	lib/MHonArc/CharEnt/CP1256.pm
	lib/MHonArc/CharEnt/CP1257.pm
	lib/MHonArc/CharEnt/CP1258.pm
	lib/MHonArc/CharEnt/CP866.pm
	lib/MHonArc/CharEnt/CP932.pm
	lib/MHonArc/CharEnt/CP936.pm
	lib/MHonArc/CharEnt/CP949.pm
	lib/MHonArc/CharEnt/CP950.pm
	lib/MHonArc/CharEnt/EUC_JP.pm
	lib/MHonArc/CharEnt/GB2312.pm
	lib/MHonArc/CharEnt/GOST19768_87.pm
	lib/MHonArc/CharEnt/HP_ROMAN8.pm
	lib/MHonArc/CharEnt/ISO8859_1.pm
	lib/MHonArc/CharEnt/ISO8859_10.pm
	lib/MHonArc/CharEnt/ISO8859_11.pm
	lib/MHonArc/CharEnt/ISO8859_13.pm
	lib/MHonArc/CharEnt/ISO8859_14.pm
	lib/MHonArc/CharEnt/ISO8859_15.pm
	lib/MHonArc/CharEnt/ISO8859_16.pm
	lib/MHonArc/CharEnt/ISO8859_2.pm
	lib/MHonArc/CharEnt/ISO8859_3.pm
	lib/MHonArc/CharEnt/ISO8859_4.pm
	lib/MHonArc/CharEnt/ISO8859_5.pm
	lib/MHonArc/CharEnt/ISO8859_6.pm
	lib/MHonArc/CharEnt/ISO8859_7.pm
	lib/MHonArc/CharEnt/ISO8859_8.pm
	lib/MHonArc/CharEnt/ISO8859_9.pm
	lib/MHonArc/CharEnt/KOI8_A.pm
	lib/MHonArc/CharEnt/KOI8_B.pm
	lib/MHonArc/CharEnt/KOI8_E.pm
	lib/MHonArc/CharEnt/KOI8_F.pm
	lib/MHonArc/CharEnt/KOI8_R.pm
	lib/MHonArc/CharEnt/KOI8_U.pm
	lib/MHonArc/CharEnt/KOI_0.pm
	lib/MHonArc/CharEnt/KOI_7.pm
	lib/MHonArc/CharEnt/VISCII.pm
	lib/MHonArc/CharMaps.pm
	lib/MHonArc/UTF8/AppleArabic.pm
	lib/MHonArc/UTF8/AppleCenteuro.pm
	lib/MHonArc/UTF8/AppleCroatian.pm
	lib/MHonArc/UTF8/AppleCyrillic.pm
	lib/MHonArc/UTF8/AppleGreek.pm
	lib/MHonArc/UTF8/AppleHebrew.pm
	lib/MHonArc/UTF8/AppleIceland.pm
	lib/MHonArc/UTF8/AppleRoman.pm
	lib/MHonArc/UTF8/AppleRomanian.pm
	lib/MHonArc/UTF8/AppleThai.pm
	lib/MHonArc/UTF8/AppleTurkish.pm
	lib/MHonArc/UTF8/BIG5_ETEN.pm
	lib/MHonArc/UTF8/BIG5_HKSCS.pm
	lib/MHonArc/UTF8/CP1250.pm
	lib/MHonArc/UTF8/CP1251.pm
	lib/MHonArc/UTF8/CP1252.pm
	lib/MHonArc/UTF8/CP1253.pm
	lib/MHonArc/UTF8/CP1254.pm
	lib/MHonArc/UTF8/CP1255.pm
	lib/MHonArc/UTF8/CP1256.pm
	lib/MHonArc/UTF8/CP1257.pm
	lib/MHonArc/UTF8/CP1258.pm
	lib/MHonArc/UTF8/CP866.pm
	lib/MHonArc/UTF8/CP932.pm
	lib/MHonArc/UTF8/CP936.pm
	lib/MHonArc/UTF8/CP949.pm
	lib/MHonArc/UTF8/CP950.pm
	lib/MHonArc/UTF8/EUC_JP.pm
	lib/MHonArc/UTF8/GB2312.pm
	lib/MHonArc/UTF8/GOST19768_87.pm
	lib/MHonArc/UTF8/HP_ROMAN8.pm
	lib/MHonArc/UTF8/ISO8859_1.pm
	lib/MHonArc/UTF8/ISO8859_10.pm
	lib/MHonArc/UTF8/ISO8859_11.pm
	lib/MHonArc/UTF8/ISO8859_13.pm
	lib/MHonArc/UTF8/ISO8859_14.pm
	lib/MHonArc/UTF8/ISO8859_15.pm
	lib/MHonArc/UTF8/ISO8859_16.pm
	lib/MHonArc/UTF8/ISO8859_2.pm
	lib/MHonArc/UTF8/ISO8859_3.pm
	lib/MHonArc/UTF8/ISO8859_4.pm
	lib/MHonArc/UTF8/ISO8859_5.pm
	lib/MHonArc/UTF8/ISO8859_6.pm
	lib/MHonArc/UTF8/ISO8859_7.pm
	lib/MHonArc/UTF8/ISO8859_8.pm
	lib/MHonArc/UTF8/ISO8859_9.pm
	lib/MHonArc/UTF8/KOI8_A.pm
	lib/MHonArc/UTF8/KOI8_B.pm
	lib/MHonArc/UTF8/KOI8_E.pm
	lib/MHonArc/UTF8/KOI8_F.pm
	lib/MHonArc/UTF8/KOI8_R.pm
	lib/MHonArc/UTF8/KOI8_U.pm
	lib/MHonArc/UTF8/KOI_0.pm
	lib/MHonArc/UTF8/KOI_7.pm
	lib/MHonArc/UTF8/VISCII.pm
@ikedas
Copy link
Member

ikedas commented Feb 3, 2021 

$ for i in lib/*.pl lib/*.pm lib/*/*.pm; do perl -Ilib -c $i || exit 1; done
Global symbol "$str" requires explicit package name at lib/base64.pl line 99.
Global symbol "$str" requires explicit package name at lib/base64.pl line 112.
Global symbol "$str" requires explicit package name at lib/base64.pl line 114.
Global symbol "$str" requires explicit package name at lib/base64.pl line 120.
lib/base64.pl had compilation errors.
$  for i in lib/*.pl lib/*/*.pm lib/*/*/*.pm; do perl -Ilib -c $i; done 2>&1 | grep error
BEGIN not safe after errors--compilation aborted at lib/base64.pl line 154.
lib/iso2022jp.pl had compilation errors.
BEGIN not safe after errors--compilation aborted at lib/mhamain.pl line 62.
lib/mhdb.pl had compilation errors.
lib/mhdysub.pl had compilation errors.
lib/mhexternal.pl had compilation errors.
BEGIN not safe after errors--compilation aborted at lib/mhfile.pl line 52.
lib/mhidxrc.pl had compilation errors.
lib/mhindex.pl had compilation errors.
lib/mhinit.pl had compilation errors.
BEGIN not safe after errors--compilation aborted at lib/mhlock.pl line 194.
lib/mhmimetypes.pl had compilation errors.
lib/mhmsgfile.pl had compilation errors.
lib/mhnote.pl had compilation errors.
lib/mhopt.pl had compilation errors.
lib/mhrcfile.pl had compilation errors.
lib/mhrcvars.pl had compilation errors.
lib/mhrmm.pl had compilation errors.
lib/mhscan.pl had compilation errors.
lib/mhsingle.pl had compilation errors.
lib/mhthread.pl had compilation errors.
lib/mhtime.pl had compilation errors.
lib/mhtxthtml.pl had compilation errors.
BEGIN not safe after errors--compilation aborted at lib/mhtxtplain.pl line 229.
lib/mhusage.pl had compilation errors.
BEGIN not safe after errors--compilation aborted at lib/mhutil.pl line 239.
lib/osinit.pl had compilation errors.
lib/readmail.pl had compilation errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikedas ikedas ikedas approved these changes

@dverdin dverdin dverdin approved these changes

@racke racke racke approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6.21 — Improve with big changes
Development

Successfully merging this pull request may close these issues.
4 participants
@ldidry @ikedas @racke @dverdin