fixed newly introduced bugs

this happens when you don't test before you release
synyx · Jun 2, 2023 · 7a8759d · 7a8759d
1 parent 6f0fa97
commit 7a8759d
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/lib/ui/widget/task_search_field.dart b/lib/ui/widget/task_search_field.dart
@@ -127,7 +127,9 @@ class _TaskSearchTextFieldState extends State<TaskSearchTextField> {
                                           ),
                                           child: WorkInterfaceIcon(origin: suggestion.origin),
                                         ),
-                                        title: Text(suggestion.displayText),
+                                        title: Text(suggestion.displayText.isNotEmpty
+                                            ? suggestion.displayText
+                                            : '<NO COMMENT>'),
                                         subtitle: Text('#${suggestion.task?.id ?? "<No Task>"}'),
                                         onTap: () {
                                           controller.closeView(null);
@@ -141,10 +143,14 @@ class _TaskSearchTextFieldState extends State<TaskSearchTextField> {
                             },
                           );
                         } else {
-                          return const ListTile(
-                            leading: Icon(Icons.search),
-                            title: Text('Start typing to search for a Task'),
-                            subtitle: Text('Hint: Try \$me or #[TicketID]'),
+                          return ListTile(
+                            leading: const Icon(Icons.search),
+                            title: const Text('Start typing to search for a Task'),
+                            subtitle: const Text('Hint: Try \$me or #[TicketID]'),
+                            onTap: () {
+                              controller.closeView(null);
+                              widget.onSubmitted?.call('');
+                            },
                           );
                         }
                       }

diff --git a/lib/util/accumulating_stream.dart b/lib/util/accumulating_stream.dart
@@ -8,7 +8,7 @@ class AccumulatingStream<T> extends Stream<List<T>> {
   AccumulatingStream(Stream<T> sourceStream) {
     _sub = sourceStream.listen((data) {
       _list.add(data);
-      _accumulatingController.add(_list);
+      _accumulatingController.add([..._list]);
     }, onError: (error) {
       _accumulatingController.addError(error);
     }, onDone: () {

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -3,7 +3,7 @@ description: A time tracking and booking tool
 
 publish_to: 'none'
 
-version: 1.4.1+7
+version: 1.4.2+8
 
 environment:
   sdk: '>=3.0.0 <4.0.0'