✨ Add tests for hcloud remediation and hetzner baremetal remediation controller #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniruddha2000
force-pushed
the
ani/issues/open-source/76
branch
from
3315bff
to
5226d1d
Compare
janiskemper
requested changes
Oct 9, 2023
aniruddha2000
force-pushed
the
ani/issues/open-source/76
branch
3 times, most recently
from
6f0fcd3
to
d29991e
Compare
janiskemper
requested changes
Oct 12, 2023
aniruddha2000
force-pushed
the
ani/issues/open-source/76
branch
from
1da6ca7
to
e0f910f
Compare
janiskemper
previously approved these changes
Oct 13, 2023
syself-bot
bot
added
the
size/L
janiskemper
approved these changes
Oct 13, 2023
|
E2Es are failing, should we block the merge like other PRs until e2e fixes? |
aniruddha2000
force-pushed
the
ani/issues/open-source/76
branch
2 times, most recently
from
7718238
to
8facc81
Compare
…troller Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>
aniruddha2000
force-pushed
the
ani/issues/open-source/76
branch
from
8facc81
to
189b6ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # https://github.com/syself/open-source/issues/76
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: