✨ update to pkgs.k8s.io #1015
Closed
✨ update to pkgs.k8s.io #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batistein
requested changes
Oct 20, 2023
| - curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add - | ||
| - echo "deb https://apt.kubernetes.io/ kubernetes-xenial main" | sudo tee -a /etc/apt/sources.list.d/kubernetes.list | ||
| - curl -fsSL https://pkgs.k8s.io/core:/stable:/v1.27/deb/Release.key | sudo gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg | ||
| - echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v1.27/deb/ /" | sudo tee /etc/apt/sources.list.d/kubernetes.list | ||
| - apt-get update | ||
| - apt-get install -y kubelet=$KUBERNETES_VERSION-00 kubeadm=$KUBERNETES_VERSION-00 kubectl=$KUBERNETES_VERSION-00 bash-completion && apt-mark hold kubelet kubectl kubeadm && systemctl enable kubelet |
There was a problem hiding this comment.
this needs to be changed to -1.1 in all files
batistein
requested changes
Oct 24, 2023
| - curl -s https://packages.cloud.google.com/apt/doc/apt-key.gpg | sudo apt-key add - | ||
| - echo "deb https://apt.kubernetes.io/ kubernetes-xenial main" | sudo tee -a /etc/apt/sources.list.d/kubernetes.list | ||
| - curl -fsSL https://pkgs.k8s.io/core:/stable:/v1.27/deb/Release.key | sudo gpg --dearmor -o /etc/apt/keyrings/kubernetes-apt-keyring.gpg | ||
| - echo "deb [signed-by=/etc/apt/keyrings/kubernetes-apt-keyring.gpg] https://pkgs.k8s.io/core:/stable:/v1.27/deb/ /" | sudo tee /etc/apt/sources.list.d/kubernetes.list |
There was a problem hiding this comment.
here we need to add a dynamic way to set the kubernetes version.
Please use the following approach: export KUBERNETES_TRIMMED=$(echo ${KUBERNETES_VERSION} | sed 's/......//') the sed command needs to be changed so that it trim the kubernetes version from v1.27.3->v1.27`
this commit updates deps from apt.kuberentes.io to pkgs.k8s.io Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
In the last commit I forgot to update the new versioning format and this commit fixes that. Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
This commit used TRIMMED_KUBERNETES_VERSION as an env variable to download packages. This way we can update with ease. Signed-off-by: Anurag <81210977+kranurag7@users.noreply.github.com>
kranurag7
force-pushed
the
kr/update-k8s-pkgs
branch
from
ed74184 to
c37f086
Compare
|
Thank you Anurag for this PR. We will upgrade to 1.28 New PR: #1073 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit updates deps from apt.kuberentes.io to pkgs.k8s.io
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1013
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs: