-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ download BM images via oci-registry. #1071
Conversation
does it make sense to have the shell script in the Go code? Shouldn't it be rather in hack/? |
1415a1b
to
381caf0
Compare
The shell script does not get executed like during build/compile time like the other scripts. The shell scripts get copied from the controller intpkg/services/baremetal/client/ssh/download-from-oci.sho the rescue-system. I added a comment at the top. I think hack/ is no good place for this script. I could copy the script into the Go code like (instead of using embed):
@janiskemper what do you think? I can copy it to hack/ if you prefer that. |
381caf0
to
801d46d
Compare
801d46d
to
d70a92d
Compare
I think I prefer having it hard-coded in the Go code! |
4ecdc8a
to
4e11b82
Compare
ok, I put the shell script into the Go code. |
91fd462
to
a859a03
Compare
a859a03
to
f484ce4
Compare
What this PR does / why we need it:
Up to now, bare-metal machine images could only be downloaded from http/https URLs.
This PR make it possible to download the machine images from oci-registries.
You can use a tool like oras to upload the machine image in tgz format to an oci registry.