Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Bump golang 1.20 => 1.21 #905

Merged
merged 1 commit into from
Sep 26, 2023
Merged

⚠️ Bump golang 1.20 => 1.21 #905

merged 1 commit into from
Sep 26, 2023

Conversation

aniruddha2000
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #894

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squash commits
  • include documentation
  • add unit tests

@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. area/github Changes made in the github directory area/hack Changes made in the hack directory labels Sep 12, 2023
@janiskemper janiskemper requested review from batistein and removed request for janiskemper September 13, 2023 06:28
@aniruddha2000
Copy link
Contributor Author

@batistein I also removed go mod tidy form here as make verify was giving issues

hack/golang-modules-update.sh Outdated Show resolved Hide resolved
@syself-bot syself-bot bot added area/code Changes made in the code directory size/L Denotes a PR that changes 200-800 lines, ignoring generated files. area/api Changes made in the api directory and removed size/M Denotes a PR that changes 50-200 lines, ignoring generated files. labels Sep 25, 2023
@syself-bot syself-bot bot added size/M Denotes a PR that changes 50-200 lines, ignoring generated files. and removed size/L Denotes a PR that changes 200-800 lines, ignoring generated files. area/api Changes made in the api directory labels Sep 26, 2023
Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>

Fix review

Signed-off-by: Aniruddha Basak <aniruddha.basak@syself.com>

:seedling: fix builder-image and some other minor fixes

Signed-off-by: Anurag <contact.anurag7@gmail.com>

update golangci-lint fixes and add comments

Signed-off-by: Anurag <contact.anurag7@gmail.com>

address yamllint conflicts

Signed-off-by: Anurag <contact.anurag7@gmail.com>
@batistein batistein merged commit 2f955dd into main Sep 26, 2023
9 checks passed
@batistein batistein deleted the ani/issue/894 branch September 26, 2023 22:37
@kranurag7 kranurag7 restored the ani/issue/894 branch September 27, 2023 04:20
@kranurag7 kranurag7 deleted the ani/issue/894 branch September 27, 2023 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Changes made in the code directory area/github Changes made in the github directory area/hack Changes made in the hack directory size/M Denotes a PR that changes 50-200 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to Go 1.21
2 participants