Introduce test_calloc and alloc #172

komark06 · 2024-03-16T04:24:04Z

This commit introduces a generic alloc function to handle both test_malloc and test_calloc operations based on the provided alloc_func_t. Additionally, it implements the test_calloc function to allocate memory and initialize it to zero.

jserv

Revise the subject of git commit message and pull request.

Quote from Wikipedia:
"code refactoring is the process of restructuring existing computer code — changing the factoring — without changing its external behavior."

It is evident that the external behavior is changed since the introduction of callc harness hook.

komark06 · 2024-03-17T04:38:12Z

Thank you for your review. I've updated the subject for both the git commit message and the pull request.

harness.c

komark06 · 2024-03-17T08:36:15Z

harness.c

+    TEST_MALLOC,
+    TEST_CALLOC,
+} alloc_t;
+


Remove the value associated with the enum to avoid the need to change its order.

Rename alloc_func_t to alloc_t for clarity.

harness.c

komark06 · 2024-03-17T09:16:07Z

Improve error messaging and precisely rename variables.

This commit introduces a generic alloc function to handle both test_malloc and test_calloc operations based on the provided alloc_func_t. Additionally, it implements the test_calloc function to allocate memory and initialize it to zero.

jserv · 2024-03-17T11:58:05Z

Thank @komark06 for contributing. Be aware of the amended subject.

komark06 · 2024-03-17T12:20:39Z

Thank you for your feedback.

This commit introduces a generic alloc function to handle both test_malloc and test_calloc operations based on the provided alloc_func_t. Additionally, it implements the test_calloc function to allocate memory and initialize it to zero.

jserv requested changes Mar 16, 2024

View reviewed changes

komark06 changed the title ~~Refactor test_calloc and introduce alloc~~ Introduce test_calloc and alloc Mar 17, 2024

jserv reviewed Mar 17, 2024

View reviewed changes