Fix a potential issue where the block_find() might return NULL #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if an assertion is actually a better idea here, as a NULL pointer would most likely be an issue in the control flow? |
qwe661234
approved these changes
Nov 16, 2023
|
This situation arises when the cache is full, yet the current test cases do not produce this particular scenario. |
Shall we extend the test cases accordingly? |
Actually, I encountered it in JIT mode and I has made the same modification in JIT branch. However, the block cache of interpreter would be clear if it is full, so it is difficult to produce this. |
Closed
vestata
pushed a commit
to vestata/rv32emu
that referenced
this pull request
Jan 24, 2025
Fix a potential issue where the block_find() might return NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
block_findmight return NULL,prev->ir_tailmight be dereferencing a NULL pointer.