rv_histogram: Make it more verbose #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jserv
reviewed
Nov 23, 2023
jserv
requested changes
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
jserv
reviewed
Nov 23, 2023
tools/rv_histogram.c
Outdated
| if (!hdr->e_shnum) { | ||
| (void) fprintf(stderr, "no section headers are found in %s\n", | ||
| elf_prog); | ||
| return 1; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.5 rule Note
tools/rv_histogram.c
Outdated
| fprintf(stderr, "elf_open failed\n"); | ||
| return 1; | ||
| (void) fprintf(stderr, "Failed to open %s\n", elf_prog); | ||
| return 1; |
Check notice
Code scanning / Cppcheck (reported by Codacy)
MISRA 15.5 rule Note
Section headers must be present for static analysis since the tool uses the SHT_PROGBITS type and SHF_EXECINSTR flag, which are defined in section headers, to determine the executable machine instructions of the target program Closed sysprog21#272
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section headers must be present for static analysis since the tool uses the
SHT_PROGBITStype andSHF_EXECINSTRflag, which are defined in section headers, to determine the executable machine instructions of the target programClosed #272