-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support RV32FC #316
Support RV32FC #316
Conversation
4d09ab6
to
8436338
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refine the README.md for the corresponding extension description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Append
Close #315
at the end of git commit message. - Attempt to run the corresponding RISC-V Architectural Tests when possible.
The current riscv-arch-test does not include a test suite for RV32FC. However, we could explore using riscv-ctg to generate a suitable test suite. |
Similar to commit cfa1c9f, we need to conduct alignment checks on load/store addresses. |
After a few days of researching riscv-ctg, I consider it is challenging to develop a related test suite in a short period. Therefore, I would like to inquire whether adding a TODO comment in the code or opening an issue, along with explaining in the README that certain parts have not undergone arch-test testing, would be a better practice. |
Rather than expanding existing compilation suites, it would be more effective to develop a straightforward, specialized test program specifically for validating RV32FC support. |
ffca3fe
to
dad7955
Compare
I ultimately managed to figure out how to use riscv-ctg to generate relevant test suites, and I also added tests for RV32FC in the CI. |
This patch is aimed at supporting RV32FC-only instructions. * The following instructions are implemented: C.FSW, C.FLW, C.FSWSP, C.FLWSP. * Update README.md for the corresponding extension description. * Add corresponding RISC-V architectural tests suites Close sysprog21#315
dad7955
to
0df83e3
Compare
Thank @fourcolor for contributing! |
This patch is aimed at supporting RV32FC-only instructions.
Close #315