Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RV32FC #316

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Support RV32FC #316

merged 1 commit into from
Jan 6, 2024

Conversation

fourcolor
Copy link
Collaborator

@fourcolor fourcolor commented Jan 1, 2024

This patch is aimed at supporting RV32FC-only instructions.

  • The following instructions are implemented: C.FSW, C.FLW, C.FSWSP, C.FLWSP.
  • Update README.md for the corresponding extension description.
  • Add corresponding RISC-V architectural tests suites

Close #315

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refine the README.md for the corresponding extension description.

Copy link
Contributor

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Append Close #315 at the end of git commit message.
  2. Attempt to run the corresponding RISC-V Architectural Tests when possible.

src/decode.c Outdated Show resolved Hide resolved
@visitorckw
Copy link
Collaborator

The current riscv-arch-test does not include a test suite for RV32FC. However, we could explore using riscv-ctg to generate a suitable test suite.

@visitorckw
Copy link
Collaborator

Similar to commit cfa1c9f, we need to conduct alignment checks on load/store addresses.

@fourcolor
Copy link
Collaborator Author

fourcolor commented Jan 4, 2024

After a few days of researching riscv-ctg, I consider it is challenging to develop a related test suite in a short period. Therefore, I would like to inquire whether adding a TODO comment in the code or opening an issue, along with explaining in the README that certain parts have not undergone arch-test testing, would be a better practice.

@jserv
Copy link
Contributor

jserv commented Jan 5, 2024

After a few days of researching riscv-ctg, I consider it is challenging to develop a related test suite in a short period.

Rather than expanding existing compilation suites, it would be more effective to develop a straightforward, specialized test program specifically for validating RV32FC support.

@fourcolor fourcolor force-pushed the support_rv32fc branch 3 times, most recently from ffca3fe to dad7955 Compare January 6, 2024 09:13
@fourcolor
Copy link
Collaborator Author

I ultimately managed to figure out how to use riscv-ctg to generate relevant test suites, and I also added tests for RV32FC in the CI.

This patch is aimed at supporting RV32FC-only instructions.
* The following instructions are implemented: C.FSW, C.FLW, C.FSWSP, C.FLWSP.
* Update README.md for the corresponding extension description.
* Add corresponding RISC-V architectural tests suites

Close sysprog21#315
@jserv jserv merged commit f842b5f into sysprog21:master Jan 6, 2024
6 checks passed
@jserv
Copy link
Contributor

jserv commented Jan 6, 2024

Thank @fourcolor for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect global/static float array initialization
3 participants