Ask to install RISCOF before running arch-test locally #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vacantron
approved these changes
Oct 27, 2024
jserv
reviewed
Oct 28, 2024
| @@ -1,3 +1,9 @@ | |||
| riscof-check: | |||
| $(Q)if [ "$(shell pip show riscof 2>&1 | head -n 1 | cut -d' ' -f1)" = "WARNING:" ]; then \ | |||
| $(PRINTF) "Run 'pip3 install git+https://github.com/riscv/riscof.git@d38859f85fe407bcacddd2efcd355ada4683aee4' to install RISCOF\n"; \ | |||
There was a problem hiding this comment.
Is this workaround still making sense?
There was a problem hiding this comment.
Is this workaround still making sense?
This may not be the solution for issue #506, but if someone attempts to run make arch-test instead of executing the script ".ci/riscv-tests.sh", the target will bail because riscof is not the default Python module. This alert can easily clarify any confusion.
There was a problem hiding this comment.
Got it. Mention the above rationale in git commit messages.
If someone attempts to run make arch-test instead of executing the script ".ci/riscv-tests.sh", the target will bail because riscof is not the default Python module. This alert can easily clarify any confusion. A specific version of RISCOF is used in CI, so requesting for that version as well.
ChinYikMing
force-pushed
the
feat/ask-to-install-riscof
branch
from
def6c3f to
f39af30
Compare
|
Thank @ChinYikMing for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A specific version of RISCOF is used in CI, so requesting for that version as well.