Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Safari version if it supports TCO for Wasm #522

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

ChinYikMing
Copy link
Collaborator

@ChinYikMing ChinYikMing commented Dec 20, 2024

Safari has supported TCO for Wasm since version 18.2. To reflect for this, check the Safari version if the host machine is running macOS.

Check Webassembly section at here.

Doom_demo.mov

@ChinYikMing ChinYikMing force-pushed the safari-wasm-lto branch 2 times, most recently from fe0dae8 to c4943cb Compare December 20, 2024 18:11
@ChinYikMing ChinYikMing changed the title Check Safari version if it supports LTO for Wasm Check Safari version if it supports TCO for Wasm Dec 20, 2024
README.md Outdated Show resolved Hide resolved
Safari has supported TCO for Wasm since version 18.2. To reflect for
this, check the Safari version if the host machine is running macOS.

Check Webassembly section at
https://webkit.org/blog/16301/webkit-features-in-safari-18-2
@ChinYikMing
Copy link
Collaborator Author

To avoid CI fails, removing redundant Wasm assets delegated to #505 since it will trigger the CI deploy-wasm which going to fail due to path changes.

@jserv jserv merged commit 5b90d0f into sysprog21:master Dec 21, 2024
8 checks passed
@jserv
Copy link
Contributor

jserv commented Dec 21, 2024

Thank @ChinYikMing for contributing!

@ChinYikMing ChinYikMing deleted the safari-wasm-lto branch December 21, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants